Respect ShowAfterCharIsDeleted and turn it off by default #5865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
changed the title
cartermp
changed the title
Contributor
Author
|
This is ready. To be clear, what this does is change this non-optional behavior:
To this behavior (if turned off):
Delete itself will not dismiss a completion list if it's still open:
|
Contributor
Author
|
I've been playing with this today, and I think the behavior feels "cleaner" with the setting off by default. |
cartermp
changed the title
Contributor
Author
|
Turning the option off by default. It just generates too much noise when it's on, and the completion list you get back is unrelated to what you had typed before. |
Contributor
Author
|
@KevinRansom @TIHan This is ready. |
6 tasks
TIHan
approved these changes
Feb 5, 2019
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Respect ShowAfterCharIsDeleted * Small refactor and modify test * ShowCharAfterDelete false by default * Delete FSharp.Core.UnitTests.dll.config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also for #5859. Based on the Roslyn code: http://source.roslyn.io/#Microsoft.CodeAnalysis.Features/Completion/CompletionServiceWithProviders.cs,478
Depends on #5863 to have any effect.