Skip to content

Removing addNewLine #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TIHan wants to merge 4 commits into from
Closed

Removing addNewLine #5941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0a37b9
Removing addNewLine
TIHan Nov 20, 2018
d237a7f
Update interactivechecker and structure tests (#4)
cartermp Nov 28, 2018
deb708d
Ti han add new line alloc fix (#5)
cartermp Nov 29, 2018
b154ea5
More test fixes (#6)
cartermp Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ti han add new line alloc fix (#5) 
* Update interactivechecker and structure tests

* Try to fix some legacy tests
  • Loading branch information
@cartermp @TIHan
cartermp authored and TIHan committed Nov 29, 2018
commit deb708d3ece5e2043f06adc8cb2fa454a3a32338
23 changes: 17 additions & 6 deletions vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.Completion.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1531,17 +1531,24 @@ let x = new MyClass2(0)
[<Test>]
member public this.``AfterConstructor.5039_1``() =
AssertAutoCompleteContainsNoCoffeeBreak
[ "let someCall(x) = null"
"let xe = someCall(System.IO.StringReader()." ]
[
"""
let someCall(x) = null
let xe = someCall(System.IO.StringReader().
""" ]
"StringReader()."
[ "ReadBlock" ] // should contain (StringReader)
[ "LastIndexOfAny" ] // should not contain (String)

[<Test>]
member public this.``AfterConstructor.5039_1.CoffeeBreak``() =
AssertAutoCompleteContains
[ "let someCall(x) = null"
"let xe = someCall(System.IO.StringReader()." ]
[
"""
let someCall(x) = null
let xe = someCall(System.IO.StringReader().
"""
]
"StringReader()."
[ "ReadBlock" ] // should contain (StringReader)
[ "LastIndexOfAny" ] // should not contain (String)
Expand Down Expand Up @@ -4913,8 +4920,12 @@ let x = query { for bbbb in abbbbc(*D0*) do

[<Test>]
member this.``BadCompletionAfterQuicklyTyping.Bug130733.NowWorks``() =
let code = [ "let someCall(x) = null"
"let xe = someCall(System.IO.StringReader() "]
let code = [
"""
let someCall(x) = null
let xe = someCall(System.IO.StringReader()
"""
]
let (_, _, file) = this.CreateSingleFileProject(code)

TakeCoffeeBreak(this.VS)
Expand Down
4 changes: 3 additions & 1 deletion vsintegration/tests/UnitTests/SignatureHelpProviderTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ type foo5 = N1.T<Param1=1,ParamIgnored= >
("type foo5 = N1.T<Param1=1,ParamIgnored",Some ("[132..160)", 1, 2, Some "ParamIgnored"));
("type foo5 = N1.T<Param1=1,ParamIgnored=",Some ("[132..160)", 1, 2, Some "ParamIgnored"))])
//Test case 5
( """let _ = System.DateTime(""",
( """
let _ = System.DateTime(
""",
[("let _ = System.DateTime(", Some ("[8..24)", 0, 0, None)) ])
]

Expand Down
5 changes: 1 addition & 4 deletions vsintegration/tests/UnitTests/VisualFSharp.UnitTests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@
<PackageReference Include="Microsoft.VisualStudio.Threading" Version="$(MicrosoftVisualStudioThreadingPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
<PackageReference Include="Microsoft.VisualStudio.Validation" Version="$(MicrosoftVisualStudioValidationPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
<PackageReference Include="NUnit" Version="$(NUnitPackageVersion)" />
<PackageReference Include="NUnit3TestAdapter" Version="$(NUnitTestAdapterPackageVersion)" />
<PackageReference Include="System.ValueTuple" Version="$(SystemValueTuplePackageVersion)" />
<PackageReference Include="VSSDK.VSHelp" Version="$(VSSDKVSHelpPackageVersion)" />
<PackageReference Include="VSSDK.VSLangProj.8" Version="$(VSSDKVSLangProj8PackageVersion)" />
Expand Down Expand Up @@ -242,10 +243,6 @@
<PackageReference Include="Microsoft.VisualStudio.Utilities" Version="$(MicrosoftVisualStudioUtilitiesPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
<PackageReference Include="Microsoft.VisualStudio.Threading" Version="$(MicrosoftVisualStudioThreadingPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
<PackageReference Include="Microsoft.VisualStudio.Validation" Version="$(MicrosoftVisualStudioValidationPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
<PackageReference Include="NUnit" Version="$(NUnitPackageVersion)" />
<PackageReference Include="System.ValueTuple" Version="$(SystemValueTuplePackageVersion)" />
<PackageReference Include="VSSDK.VSHelp" Version="$(VSSDKVSHelpPackageVersion)" PrivateAssets="all" ExcludeAssets="runtime;contentFiles;build;analyzers;native" />
<PackageReference Include="VSSDK.VSLangProj.8" Version="$(VSSDKVSLangProj8PackageVersion)" PrivateAssets="all" ExcludeAssets="contentFiles;build;analyzers;native" />
</ItemGroup>

</Project>