-
Notifications
You must be signed in to change notification settings - Fork 839
Disable XMLDocCommandService due to UI delays #6087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable XMLDocCommandService due to UI delays #6087
Conversation
|
What did the feature do (when it once worked)? |
|
XML doc generation via |
|
Does disabling this completely remove any parsing of |
|
@abelbraaksma No, this is for generating boilerplate in code. It has nothing to do with QuickInfo, which is what shows in tooltips. |
TIHan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is 'ok' to disable for now. It currently doesn't work, which is a regression anyway.
This isn't a critical feature and based on @cartermp 's analysis it has the potential to cause UI delays. In that sense, it's fine disable it until we figure out a better solution/implementation that will not cause UI delay.
|
In terms of how to implement this without causing big UI delays, we'd need to do something similar to what Roslyn does and work off of the |
|
I'd wonder if it is possible if a task like this is required to hold the whole file contents to begin with. In essence, you'd need to find the doc comments (which are line comments) and one or two lines that follow them (the identifier). What I am trying to say is: can't we use a streaming technique with a line-by-line read and only keep what we need to keep and discard the other lines? Wouldn't that possibly lead to a lot less GC2 collections and completely remove the LOH problem? |
|
|
See #6076