Tests for coreclr #6151
Merged
Tests for coreclr #6151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KevinRansom
commented
Jan 28, 2019
KevinRansom
commented
- During the build build a nuget package with the FSharp.Core unit tests that the coreclr team can use to verify they haven't broken us again.
- FSharp.Core on master branch puts the net45 resources in the wrong place.
- Add support for xunit to FSharp.Core unit tests, because coreclr uses xunit.
- Ensure that tests can be built with an out of the box VS, and not require any VFS repo build magic.
- Remove the app.config for the unittests, they are no longer needed.
KevinRansom
force-pushed
the
testsforcoreclr
branch
5 times, most recently
from
60ef93e to
afe7cd1
Compare
KevinRansom
force-pushed
the
testsforcoreclr
branch
from
7161610 to
4e97752
Compare
brettfo
suggested changes
Feb 8, 2019
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="XliffTasks" Version="$(XliffTasksPackageVersion)" /> | ||
| <PackageReference Include="XliffTasks" Version="$(XliffTasksPackageVersion)" PrivateAssets="All" /> |
| </None> | ||
|
|
||
| <Content Include="$(MSBuildProjectDirectory)\**\*.*" | ||
| Exclude="$(MSBuildProjectDirectory)\bin\**\*.*;$(MSBuildProjectDirectory)\obj\**\*.*;$(MSBuildProjectDirectory)\FSharp.Core\SampleTuples\**\*.*;$(MSBuildProjectDirectory)\Directory.Build.props;$(MSBuildProjectDirectory)\Directory.Build.targes;"> |
Member
There was a problem hiding this comment.
Typo: Directory.BUild targes -> Directory.Build.targets
More importantly, what specifically are you trying to include? This line looks terrible.
Contributor
Author
There was a problem hiding this comment.
I don't want to include the SampleTuples subdirectory. And the intermediate and output directories, which probably now are correctly in the artifacts directory.
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <DefineConstants Condition="'$(UnitTestType)' == 'xunit'">$(DefineConstants);XUNIT</DefineConstants> |
Member
There was a problem hiding this comment.
You're explicitly setting $(UnitTestType) to xunit a few lines up, so this section doesn't really do anything.
| <Pattern1>FSCoreVersion</Pattern1> | ||
| <Replacement1>$(FSCoreVersion)</Replacement1> | ||
| </CopyAndSubstituteText> | ||
| <Compile Include="SurfaceArea.coreclr.fs" Condition="$(TargetFramework.StartsWith('netcoreapp')) == true and '$(FX_VERIFY_SURFACEAREA)' == 'true'" /> |
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="$(FSharpSourcesRoot)\fsharp\FSharp.Core\FSharp.Core.fsproj" /> | ||
| <Content Include="**/*" Exclude="**/*.bak;Directory.Build.Props;Directory.Build.targets" CopyToOutputDirectory="never" /> |
Member
There was a problem hiding this comment.
What specifically would you like to include?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.