debug fixes #6170
Merged
debug fixes #6170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
KevinRansom
approved these changes
Jan 31, 2019
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Once tests are passing this is fine.
cartermp
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few problems while running VisualFSharp tools in debug mode on some F# scripts. These fixes don't affect the actual product behaviour
We are getting an assert in the MSBuild resolution while processing scripts. The problem is that old broken code to compute the target framework version is kicking in and evaluating to
"v4.0"which is no longer even supported. This computation of target framework version is only relevant in secondary stages of processing scripts and should just be HighestInstalledFrameworkVersionThe Simulated MSBuild code was failing if the gac directory does not exist. This code is only used by FCS. and was only failing for the .NET Standard/Core version of FCS This is now protected bya
Directory.Exists