Skip to content

Rev FSharp.core nuget package version #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 2 commits into from
Feb 6, 2019
Merged

Rev FSharp.core nuget package version #6205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ccba8b
Rev FSharp.core nuget package version
KevinRansom Feb 6, 2019
51e52fc
Update test
KevinRansom Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build/targets/AssemblyVersions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@

<FSLanguageVersion>4.6</FSLanguageVersion>
<FSCoreMajorVersion>$(FSLanguageVersion)</FSCoreMajorVersion>
<FSCorePackageVersion>$(FSCoreMajorVersion).1</FSCorePackageVersion>
<FSCorePackageVersion>$(FSCoreMajorVersion).2</FSCorePackageVersion>
<FSCoreVersion>$(FSCoreMajorVersion).0.0</FSCoreVersion>

<FSPackageMajorVersion>10.4</FSPackageMajorVersion>
<FSPackageVersion>$(FSPackageMajorVersion).1</FSPackageVersion>
<FSPackageVersion>$(FSPackageMajorVersion).2</FSPackageVersion>
<FSProductVersion>$(FSPackageMajorVersion).0.0</FSProductVersion>

<VSMajorVersion>16</VSMajorVersion>
<VSMinorVersion>1</VSMinorVersion>
<VSMinorVersion>0</VSMinorVersion>
<VSGeneralVersion>$(VSMajorVersion).0</VSGeneralVersion>
<VSAssemblyVersion>$(VSMajorVersion).$(VSMinorVersion).0.0</VSAssemblyVersion>

Expand Down
2 changes: 1 addition & 1 deletion src/fsharp/FSharp.Build/Microsoft.FSharp.NetSdk.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and

<PropertyGroup>
<DefaultValueTuplePackageVersion>4.4.0</DefaultValueTuplePackageVersion>
<DefaultFSharpCorePackageVersion>4.6.1</DefaultFSharpCorePackageVersion>
<DefaultFSharpCorePackageVersion>4.6.2</DefaultFSharpCorePackageVersion>
<ValueTupleImplicitPackageVersion>$(DefaultValueTuplePackageVersion)</ValueTupleImplicitPackageVersion>
<FSharpCoreImplicitPackageVersion>$(DefaultFSharpCorePackageVersion)</FSharpCoreImplicitPackageVersion>
</PropertyGroup>
Expand Down
8 changes: 4 additions & 4 deletions tests/fsharp/single-test.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ let generateOverrides =
</Project>"
template

let generateProjectArtifacts (pc:ProjectConfiguration) targetFramework =
let generateProjectArtifacts (pc:ProjectConfiguration) targetFramework configuration =
let computeSourceItems addDirectory addCondition (compileItem:CompileItem) sources =
let computeInclude src =
let fileName = if addDirectory then Path.Combine(pc.SourceDirectory, src) else src
Expand Down Expand Up @@ -172,7 +172,7 @@ let generateProjectArtifacts (pc:ProjectConfiguration) targetFramework =
|> replaceTokens "$(OPTIMIZE)" optimize
|> replaceTokens "$(DEBUG)" debug
|> replaceTokens "$(TARGETFRAMEWORK)" targetFramework
|> replaceTokens "$(RestoreFromArtifactsPath)" (Path.GetFullPath(__SOURCE_DIRECTORY__) + "/../../artifacts")
|> replaceTokens "$(RestoreFromArtifactsPath)" (Path.GetFullPath(__SOURCE_DIRECTORY__) + "/../../artifacts/packages/" + configuration)

generateProjBody

Expand Down Expand Up @@ -218,7 +218,7 @@ let singleTestBuildAndRunCore cfg copyFiles p =
let executeFsc testCompilerVersion targetFramework =
let propsBody = generateProps testCompilerVersion
emitFile propsFileName propsBody
let projectBody = generateProjectArtifacts pc targetFramework
let projectBody = generateProjectArtifacts pc targetFramework cfg.BUILD_CONFIG
emitFile projectFileName projectBody
use testOkFile = new FileGuard(Path.Combine(directory, "test.ok"))
exec { cfg with Directory = directory } cfg.DotNetExe (sprintf "run -f %s" targetFramework)
Expand All @@ -228,7 +228,7 @@ let singleTestBuildAndRunCore cfg copyFiles p =
let executeFsi testCompilerVersion targetFramework =
let propsBody = generateProps testCompilerVersion
emitFile propsFileName propsBody
let projectBody = generateProjectArtifacts pc targetFramework
let projectBody = generateProjectArtifacts pc targetFramework cfg.BUILD_CONFIG
emitFile projectFileName projectBody
use testOkFile = new FileGuard(Path.Combine(directory, "test.ok"))
exec { cfg with Directory = directory } cfg.DotNetExe "build /t:RunFSharpScript"
Expand Down
2 changes: 1 addition & 1 deletion vsintegration/ProjectTemplates/ConsoleProject/Template/ConsoleApplication.vstemplate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<WizardData>
<packages repository="extension" repositoryId="VisualFSharpTemplates">
<package id="System.ValueTuple" version="4.4.0" />
<package id="FSharp.Core" version="4.6.1" />
<package id="FSharp.Core" version="4.6.2" />
</packages>
</WizardData>
</VSTemplate>
2 changes: 1 addition & 1 deletion vsintegration/ProjectTemplates/LibraryProject/Template/Library.vstemplate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<WizardData>
<packages repository="extension" repositoryId="VisualFSharpTemplates">
<package id="System.ValueTuple" version="4.4.0" />
<package id="FSharp.Core" version="4.6.1" />
<package id="FSharp.Core" version="4.6.2" />
</packages>
</WizardData>
</VSTemplate>
2 changes: 1 addition & 1 deletion vsintegration/ProjectTemplates/TutorialProject/Template/Tutorial.vstemplate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<WizardData>
<packages repository="extension" repositoryId="VisualFSharpTemplates">
<package id="System.ValueTuple" version="4.4.0" />
<package id="FSharp.Core" version="4.6.1" />
<package id="FSharp.Core" version="4.6.2" />
</packages>
</WizardData>
</VSTemplate>