Anonymous record support for expressions in FCS #6257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tests added, this is now ready. It wasn't hard change |
Contributor
Author
|
I've enabled |
Contributor
Author
|
FCS docs also updated |
Contributor
|
Linking #6189 |
Contributor
Author
|
OK this is ready |
cartermp
approved these changes
Feb 21, 2019
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Change looks good and simple (looks like there's a bit of test file cleanup as well).
Contributor
|
@alfonsogarciacaro Does this look good enough? I imagine so, since Fable code just works off of the types that have been adjusted. |
Member
|
Once this gets merged I can do a merge+release of FCS to support Fable. |
Contributor
Author
|
@cartermp I think it's all the info we're able to give :-) |
Contributor
|
Fable REPL (Try a hard reload to clear the browser cache if it doesn't work) 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing to follow