Avoid multiple dotnet cli downloads #6272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
reviewed
Feb 22, 2019
|
|
||
| let dotnetExePath = DotNetCli.InstallDotNetSDK "2.1.403" | ||
| let dotnetExePath = | ||
| // Build.cmd normally downloads a dotnet cli to: <repo-root>\artifacts\toolset\dotnet |
Contributor
There was a problem hiding this comment.
Does build.sh do this as well?
Also when @brettfo finishes up the arcade work it won't be build.cmd/build.sh anymore
Contributor
Author
There was a problem hiding this comment.
@cartermp build.sh in fcs calls build.fsx :-)
and build.sh in root builds a makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst analyzing this: #6271
I noticed and got irritated by the multiple dotnet clis we download, also the current script downloads a dotnet/cli, every single build when building fcs.
Anyway updated the script, to peek in the artifacts directory and see if dotnet cli has already been downloaded, if so then I use it.
Kevin