warnings as error again #6292
Merged
warnings as error again #6292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Feb 27, 2019
KevinRansom
suggested changes
Feb 27, 2019
Contributor
Author
|
Annoying unrelated test failures. Ugh and a few similar |
Contributor
Author
|
OK I updated this to I unfortunately can't enable all warnings-as-errors because some projects generate Nuget warnings. So I've just listed the two most important warnings (unused variables and match failures). I guess we could use F# |
KevinRansom
approved these changes
Feb 28, 2019
Contributor
Author
|
Dodgy test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn warnings-as-errors back on for all the core F# projects. This got lost somewhere along the way