Skip to content

Compat fix for 6258 and fix deterministic flag #6295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 7 commits into from
Mar 1, 2019
Merged

Compat fix for 6258 and fix deterministic flag #6295

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05d9a06
Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe…
dsyme Feb 10, 2019
0abe361
make fsc.exe 32-bit for compat
dsyme Feb 28, 2019
863c50c
make fsc.exe 32-bit for compat
dsyme Feb 28, 2019
da9f58c
improve diagnostics
dsyme Feb 28, 2019
8a14d5e
fix tests
dsyme Feb 28, 2019
e00e1db
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Feb 28, 2019
f41723a
fix determinism
dsyme Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix determinism
  • Loading branch information
@dsyme
dsyme committed Mar 1, 2019
commit f41723a724d4583aacaf0beab901097e67ad52a3
5 changes: 2 additions & 3 deletions src/absil/ilwrite.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2857,9 +2857,8 @@ and newGuid (modul: ILModuleDef) =

and deterministicGuid (modul: ILModuleDef) =
let n = 16909060
let m = hash n
let m2 = hash modul.Name
[| b0 m; b1 m; b2 m; b3 m; b0 m2; b1 m2; b2 m2; b3 m2; 0xa7uy; 0x45uy; 0x03uy; 0x83uy; b0 n; b1 n; b2 n; b3 n |]
let m2 = Seq.sum (Seq.mapi (fun i x -> i + int x) modul.Name) // use a stable hash
[| b0 n; b1 n; b2 n; b3 n; b0 m2; b1 m2; b2 m2; b3 m2; 0xa7uy; 0x45uy; 0x03uy; 0x83uy; b0 n; b1 n; b2 n; b3 n |]

and GetModuleAsRow (cenv:cenv) (modul: ILModuleDef) =
// Store the generated MVID in the environment (needed for generating debug information)
Expand Down