Skip to content

Possible fix for script processing #6301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 3 commits into from
Mar 9, 2019
Merged

Possible fix for script processing #6301

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4948856
Possible fix for script processing
dsyme Mar 1, 2019
e01910a
Update FSharpProjectOptionsManager.fs
dsyme Mar 1, 2019
54c9213
add test files and improve fix
cartermp Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update FSharpProjectOptionsManager.fs
  • Loading branch information
@dsyme
dsyme authored Mar 1, 2019
commit e01910af67853a8a9b96ceeac6d8521e92d05783
2 changes: 1 addition & 1 deletion vsintegration/src/FSharp.Editor/LanguageService/FSharpProjectOptionsManager.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspaceImpl,

let rec tryComputeOptionsByFile (document: Document) cancellationToken =
async {
let! fileStamp = document.GetTextVersionAsync(cancellationToken) |> Async.AwaitTask
match singleFileCache.TryGetValue(document.Id) with
| false, _ ->
let! sourceText = document.GetTextAsync(cancellationToken) |> Async.AwaitTask
let! fileStamp = document.GetTextVersionAsync(cancellationToken) |> Async.AwaitTask
let! scriptProjectOptions, _ = checkerProvider.Checker.GetProjectOptionsFromScript(document.FilePath, sourceText.ToFSharpSourceText(), DateTime.Now)
let projectOptions =
if isScriptFile document.FilePath then
Expand Down