Skip to content

Code cleanup in optimizer #6313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsyme merged 2 commits into from
Mar 9, 2019
Merged

Code cleanup in optimizer #6313

dsyme merged 2 commits into from
Mar 9, 2019

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Mar 9, 2019

Some simple code cleanup

  • comments
  • variable renaming to remove use of primes

cartermp
cartermp approved these changes Mar 9, 2019
View reviewed changes
src/fsharp/Optimizer.fs
else MakeValueInfoWithCachedSize vdepth vinfo

//-------------------------------------------------------------------------
// What we know about the world
Copy link
Contributor

@cartermp cartermp Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Contributor Author

@dsyme dsyme Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@dsyme dsyme closed this Mar 9, 2019
@dsyme dsyme reopened this Mar 9, 2019
@dsyme
Copy link
Contributor Author

dsyme commented Mar 9, 2019

Dodgy test

Failed   TypeProvider.Disposal.SmokeTest1
Error Message:
   Check1, countDisposals() < i, iteration 21
  Expected: True
  But was:  False

Stack Trace:
   at Tests.LanguageService.Script.UsingMSBuild.TypeProviderDisposalSmokeTest(Boolean clearing) in D:\a\1\s\vsintegration\tests\UnitTests\LegacyLanguageService\Tests.LanguageService.Script.fs:line 1615
   at Tests.LanguageService.Script.UsingMSBuild.TypeProvider.Disposal.SmokeTest1() in D:\a\1\s\vsintegration\tests\UnitTests\LegacyLanguageService\Tests.LanguageService.Script.fs:line 1649

@dsyme dsyme merged commit 8671454 into dotnet:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

@cartermp cartermp cartermp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsyme @KevinRansom @cartermp