Cleanup semicolons, add documentation #6316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@KevinRansom this is ready, thanks |
Contributor
Author
|
I added some documentation and cleanup in IlxGen.fs to this |
Contributor
Author
|
Ugh, hitting this problem again I'll add diagnostics to try to work out what's going on |
TIHan
approved these changes
Mar 11, 2019
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
Looks good. Clean and simple.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing real work I like to talk about bike sheds.
This adds "unnecessary semicolons at end of lines" to
tests/scripts/codingConventions.fsxand eliminates nearly all of these suckers from our codebaseMore seriously, this is aimed at reducing the "WTF" factor when coming to the codebase