[WIP] Consume XLF Files #6334
Closed
[WIP] Consume XLF Files #6334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons that have been lost to the sands of time, F# treats the "en" locale as a localization target even though all the translatable resources start out in English. The build produces en resource assemblies, which are never used, while still embedding the original English resources in the primary assemblies for use as the neutral locale. This is unnecessary and causes problems elsewhere. This commit removes en from the list of localization targets and deletes all the *.en.xlf files.
Consume the localized resources produced for menu items, buttons, etc. in FSharp.ProjectSystem.FSharp.dll. Because of conflicts caused by having en as both a localization target and being used as the "neutral" locale, localization of MenusAndCommands.vsct was turned off. We still had the associated .xlf files and the loc team was periodically updating them, but we never consumed their contents. As such, all the text from that file is unlocalized. Now that we've stopped treating en as a localization target we can turn it back on. This does require adding an MSBuild target to work around a different issue (namely, the VSSDK really, really wants you to put *all* resources in separate assemblies).
Author
|
@brettfo @KevinRansom FYI. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this as-is. This is meant only to demonstrate some of the changes necessary to fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/817160/.
Note also the added target shouldn't be necessary once F# is migrated to use dotnet/Arcade as I believe it already exists in that SDK.