Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Mar 20, 2019

At the start of a day of coding I like to warm up by working on the bike sheds. Painting all of them the same color and making sure their spacing and measurements are all the same, or at least not quite so wildly inconsistent.

src/absil/il.fs Outdated
let b = new System.Text.StringBuilder(100)
let add (s:string) = (b.Append(s) |> ignore)
let addC (s:char) = (b.Append(s) |> ignore)
let add (s: string) = (b.Append(s) |> ignore)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parens on the right side can go as well

@dsyme
Copy link
Contributor Author

dsyme commented Mar 20, 2019

Great, this is green. @TIHan can you review so we can get this in and be done with it? Thanks

Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super :)

@dsyme
Copy link
Contributor Author

dsyme commented Mar 20, 2019

Unrelated flakey test failure:

[xUnit.net 00:01:10.40]     FSharp.Core.UnitTests.FSharp_Core.Microsoft_FSharp_Control.MailboxProcessorType.Receive handles cancellation token [FAIL]
Failed   FSharp.Core.UnitTests.FSharp_Core.Microsoft_FSharp_Control.MailboxProcessorType.Receive handles cancellation token
Error Message:
 NUnit.Framework.AssertionException : Exception of type 'NUnit.Framework.AssertionException' was thrown.
Stack Trace:
   at NUnit.Framework.Assert.AreEqual(Object expected, Object actual, String message) in /Users/vsts/agent/2.148.1/work/1/s/tests/FSharp.Core.UnitTests/NUnitFrameworkShims.fs:line 94
   at FSharp.Core.UnitTests.FSharp_Core.Microsoft_FSharp_Control.MailboxProcessorType.Receive handles cancellation token() in /Users/vsts/agent/2.148.1/work/1/s/tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/MailboxProcessorType.fs:line 103

Since this was green and only a tiny change was added I will pull this

@dsyme dsyme merged commit d5f5bd0 into dotnet:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants