Skip to content

Clear status bar after navigable symbol is resolved #6373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 2 commits into from
Mar 28, 2019
Merged

Clear status bar after navigable symbol is resolved #6373

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74f83e1
Clear status bar after navigable symbol is resolved
cartermp Mar 22, 2019
4adf551
yert
cartermp Mar 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
yert
  • Loading branch information
@cartermp
cartermp committed Mar 22, 2019
commit 4adf5513ecfa86a4bf9428a78f9979ca694d86a6
3 changes: 1 addition & 2 deletions vsintegration/src/FSharp.Editor/Navigation/NavigableSymbolsService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ type internal FSharpNavigableSymbolSource(checkerProvider: FSharpCheckerProvider
try
// This call to Wait() is fine because we want to be able to provide the error message in the status bar.
gtdTask.Wait()
statusBar.Clear()

if gtdTask.Status = TaskStatus.RanToCompletion && gtdTask.Result.IsSome then
let navigableItem, range = gtdTask.Result.Value
Expand All @@ -62,8 +63,6 @@ type internal FSharpNavigableSymbolSource(checkerProvider: FSharpCheckerProvider
let declarationSpan = Span(declarationTextSpan.Start, declarationTextSpan.Length)
let symbolSpan = SnapshotSpan(snapshot, declarationSpan)

statusBar.Clear()

return FSharpNavigableSymbol(navigableItem, symbolSpan, gtd, statusBar) :> INavigableSymbol
else
statusBar.TempMessage(SR.CannotDetermineSymbol())
Expand Down