Skip to content

Improve Portable PDB debugging in FSharp.Private.Compiler.dll #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 5 commits into from
Mar 29, 2019
Merged

Improve Portable PDB debugging in FSharp.Private.Compiler.dll #6383

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a60e099
Fix portable pdb writing
KevinRansom Mar 27, 2019
61aed5f
enable portable pdbs for fsharp.private.compiler.dll
KevinRansom Mar 27, 2019
831ae68
feedback
KevinRansom Mar 29, 2019
403e370
Merge branch 'master' into symbols
KevinRansom Mar 29, 2019
6fcfaf9
Release build
KevinRansom Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
enable portable pdbs for fsharp.private.compiler.dll
  • Loading branch information
@KevinRansom
KevinRansom committed Mar 27, 2019
commit 61aed5febb8704e05c6915b40075539727bf444c
4 changes: 0 additions & 4 deletions src/fsharp/FSharp.Compiler.Private/FSharp.Compiler.Private.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,9 @@
<OtherFlags>$(OtherFlags) --warnon:1182 --maxerrors:20 --extraoptimizationloops:1</OtherFlags>
<UseAssetTargetFallback>true</UseAssetTargetFallback>
<Tailcalls>true</Tailcalls> <!-- .tail annotations always emitted for this binary, even in debug mode -->
<SkipPDBConversion>true</SkipPDBConversion>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'net46' AND '$(OS)' == 'Windows_NT'">
<!-- portable PDBs can't be properly generated for this assembly, see https://github.com/Microsoft/visualfsharp/issues/5976 -->
<DebugType>full</DebugType>
<EnableSourceLink>false</EnableSourceLink>
</PropertyGroup>

<PropertyGroup Condition="$(TargetFramework.StartsWith('netstandard')) AND '$(OS)' == 'Windows_NT'">
Expand Down