Always build FSharp.Core.UnitTests against the FSharp.Core in the repository #6384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR: here #6360 correctly identifies that the new build uses FSharp.Core from nuget for the FSharp.Core unit tests.
Thanks @Frassel for logging the issue, and providing a fix.
The fix is to ensure that the build correctly sets BUILD_IN_FSHARP_REPOSITORY to true
The place to ensure that is in FSharpBuild.Directory.Build.props
The value is also set in FSharpTest.Directory.Build.props. I will review with @brettfo whether this props file is still necessary. I can think of a couple of test cases that rely on it, but maybe it can now be made to disappear under arcade.
This pr also adds a --testFSharpCore for flag to run just the fsharp.core.unittests on desktop and coreclr.
/cc @Frassel, @dsyme