Re-enable ngen for desktop compiler builds #6386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Arcade build and it's signing approach and requirement to not require administrator permissions we lost the ability to NGEN the protocompiler and desktop compiler build in the OSS repo.
This PR , re-enables that … because let's face it, Ngen is free speed.
NGen is silently enabled, when you open an administrator window and build the repo. If you open a non-elevated build window, or build from an unelevated VS then you will get non-ngen behavior.
When the build is run under the CI it will run without Administrator privileges.
When built with:
Public signed assemblies cannot be NGEN'd, because they claim to be full signed, when they are only partially signed, so NGEN fails when verifying hashes.