Add fsi to proto build, move version validation to ci only #6387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
(@KevinRansom Just to say I've always wanted to avoid FSI in the proto build, since I can imagine a future where FSI is a separate tool in a separate repository. But it's no big deal, and maybe these version checks can be removed altogether anyway) |
Contributor
Author
brettfo
reviewed
Mar 28, 2019
| Copy-Item "$ArtifactsDir\bin\fsc\$bootstrapConfiguration\$bootstrapTfm\*" -Destination $dir | ||
|
|
||
| Write-Host "Cleaning Bootstrap compiler artifacts" | ||
| Run-MSBuild $projectPath "/t:Clean" -logFileName "BootstrapClean" -configuration $bootstrapConfiguration |
Member
There was a problem hiding this comment.
Why is the clean step getting removed?
Contributor
Author
There was a problem hiding this comment.
Because it just deletes a few files from fsc\Proto\net46, and looks odd.
Contributor
Author
Contributor
Author
|
@dsyme, The proto compiler is really an artifact of this repo, we just need one that we can rely on for build tasks. We could either use the LKG or build and execute one in the build. For now it seems as if building one during the proto build phase is a reasonable choice, and gives us better coverage. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So .. at the end of the build it does some versioning validation, it takes a while and only really needs doing on the ci and official builds. It used the product build version of fsi.exe, which is not always built.