Skip to content

update FCS dependencies #6388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 4 commits into from
Mar 29, 2019
Merged

update FCS dependencies #6388

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f8918d
update FCS dependencies
dsyme Mar 28, 2019
8b336e7
update FCS dependencies
dsyme Mar 28, 2019
1cd2401
fix up build
dsyme Mar 28, 2019
b9883a0
code review
dsyme Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
code review
  • Loading branch information
@dsyme
dsyme committed Mar 28, 2019
commit b9883a05f68004f41bd2bf11b2f3f3579db01a69
10 changes: 7 additions & 3 deletions fcs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@ Basically we are packaging up the compiler as a DLL and publishing it as a NuGet
There are subtle differences between FSharp.Compiler.Service and FSharp.Compiler.Private (shipped with the Visual F# Tools)

- FCS has a public API
- FCS is built against **.NET 4.5** and **FSharp.Core 4.0.0.0** to give broader reach

- FCS is built against **.NET 4.6.1** and **FSharp.Core NuGet 4.6.2** to give broader reach

- FCS has a NuGet package
- FCS has a .NET Standard 1.6 version in the nuget package

- FCS has a .NET Standard 2.0 version in the nuget package

- FCS testing also tests the "Project Cracker" (see below)
- FCS doesn't add the System.ValueTuple.dll reference by default, see ``#if COMPILER_SERVICE_AS_DLL`` in compiler codebase

- FCS doesn't add the System.ValueTuple.dll reference by default, see ``#if COMPILER_SERVICE_AS_DLL`` in compiler codebase

## Version Numbers

Expand Down
2 changes: 1 addition & 1 deletion fcs/docsrc/content/react.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ referenced DLLs may change on disk, or referenced files may change.
The ``FSharpChecker`` component from FSharp.Compiler.Service does _not_ actively "listen"
to changes in the file system. However ``FSharpChecker`` _does_ repeatedly ask for
time stamps from the file system which it uses to decide if recomputation is needed.
FCS doesn�t listen for changes directly - for example, it creates no ``FileWatcher`` object (and the
FCS doesn't listen for changes directly - for example, it creates no ``FileWatcher`` object (and the
``IFileSystem`` API has no ability to create such objects). This is partly for legacy reasons,
and partly because some hosts forbid the creation of FileWatcher objects.

Expand Down