When a solution becomes unloaded, we should clear F#'s cache #6420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Apr 3, 2019
TIHan
added a commit
to TIHan/visualfsharp
that referenced
this pull request
Apr 5, 2019
KevinRansom
pushed a commit
that referenced
this pull request
Apr 16, 2019
* Trying to optimize span in for loop * Added Span_GetItem call * Almost success with optimization * Fixed code gen * Added Span optimization tests * Added ReadOnlySpan opt * Cleaning up tests * Moving tests around * Trying to figure out span tests * Trying to fix some tests * Trying to get some more tests passing * Fixed range * Trying to get tests to pass again * Fixing tests for netcore * Fix build * When a solution becomes unloaded, we should clear F#'s cache (#6420) * Changing if directives * Simplifying * Using a type shape for span optimization * Fixing one test * Drastically simplified looking at the type shape for Span * Simplified a bit more * RunScript has expected error messages * Add back net472 * Feedback * Update SpanOptimizationTests.fs * Update SpanOptimizationTests.fs
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Trying to optimize span in for loop * Added Span_GetItem call * Almost success with optimization * Fixed code gen * Added Span optimization tests * Added ReadOnlySpan opt * Cleaning up tests * Moving tests around * Trying to figure out span tests * Trying to fix some tests * Trying to get some more tests passing * Fixed range * Trying to get tests to pass again * Fixing tests for netcore * Fix build * When a solution becomes unloaded, we should clear F#'s cache (dotnet#6420) * Changing if directives * Simplifying * Using a type shape for span optimization * Fixing one test * Drastically simplified looking at the type shape for Span * Simplified a bit more * RunScript has expected error messages * Add back net472 * Feedback * Update SpanOptimizationTests.fs * Update SpanOptimizationTests.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a solution becomes unloaded, we should clear F#'s cache. We used to do this, but I believe I removed it a while ago. This fixes an OOM issue where I continually open and close big solutions.