Merge master to dev16.1 #6500
Merged
Merge master to dev16.1 #6500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use mutable instead of ref * avoid calling List.Length just to compare if the length is equal (I believe this should be reusable function outside, but don't know where it is if it exists, or where to put it) * shorten call to FormatMethInfoSig which is repeated more than any others in many places * for loop instead of List.iter * declare local instead of match over long expression * remove spurious calls to ignore and unit
…ngle compile error message.
* update the error names in FSComp to keep the typrelNoImplementationGiven prefix atomic
….fs fsharpqa tests. Note that multiline error messages can't be matched as precisely, we need to drop the status="error" and id="..." from the <Expects> tags to match individual lines of the message separately.
…409.2 (#6482) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19209.2
* Don't remove inlined mutable vars * Added tests for inlined mutable vars
…410.7 (#6496) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19210.7
AllMethInfosOfTypeInScope with shortcut of extension methods
…reporting error messages: report a list of missing overrides
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into dev16.1.
git fetch --all git checkout merges/master-to-dev16.1 git reset --hard upstream/dev16.1 git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-dev16.1 --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.