Permit reduction of Some allocations for optional arguments
#6533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for optional arguments
Contributor
Author
|
OK, well, no tests failed so we have to add a test... |
KevinRansom
suggested changes
Apr 16, 2019
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Minor comment change, then this looks good to go.
| // #NoMono #NoMT #CodeGen #EmittedIL #Tuples | ||
| type A() = class end | ||
|
|
||
| // A code+optimization pattern used in Fabulous, see https://github.com/Microsoft/visualfsharp/issues/6532 |
Contributor
There was a problem hiding this comment.
Can we lose this comment. It makes life tricky when doing a pedigree scan.
KevinRansom
approved these changes
Apr 16, 2019
Contributor
Author
|
What's a "pedigree scan"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #6532.
Testing would be needed, however first I'll run this through CI as existing IL code generation testing may actually catch this.