tooling perf: range.DebugCode reading file without checks may have impact on ability to debug default fsi.exe session #6595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S while debugging. It seems a bit smoother when working with FSharp.sln fsi.exe but not tried under trace / profiling
Contributor
Author
|
this is the visible side effect of this PR. |
dsyme
approved these changes
Apr 23, 2019
KevinRansom
approved these changes
Apr 24, 2019
Contributor
|
Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if this is why I'm seeing "evaluating local variables..." in VS while debugging fsi.exe (the default session doesn't have a valid file name AFAIU):
It seems a bit smoother when working with FSharp.sln fsi.exe but not tried under trace / profiling, if someone with better hardware / tooling could give it a shot.
I'm stepping through the code I've highlighted there: #6578 (comment)
edit: we may want to introduce a "going to read this file" monad or something in the code to avoid this, if it would make any sense (can't author it, not sure if it fits compiler or desired idioms).