Skip to content

improve compiler error message for failed overload resolution #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 96 commits into from
Feb 19, 2020
Merged

improve compiler error message for failed overload resolution #6596

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
1f68b17
migrate (as a separate copy) fsharpqa tests that are going to be impa…
smoothdeveloper Apr 30, 2019
d0630a3
update the .bsl files
smoothdeveloper Apr 30, 2019
c01329f
remove comments that are handled by baseline files, update baseline f…
smoothdeveloper Apr 30, 2019
56fbe7a
remove the migrated tests from fsharpqa tests
smoothdeveloper Apr 30, 2019
632f8ee
need to be more careful when migrating those
smoothdeveloper Apr 30, 2019
bcd4068
testing if running the test with .fs instead of .fsx makes them work …
smoothdeveloper Apr 30, 2019
55bc729
exclude migrated fsharpqa from dotnet core run
smoothdeveloper Apr 30, 2019
823c53a
sample test in fsharpqa (can't run locally for now)
smoothdeveloper Apr 20, 2019
9671f33
trying to make it green now.
smoothdeveloper Apr 21, 2019
2eb3b56
checking if this path is covered by a test, trying to identify how to…
smoothdeveloper Apr 21, 2019
7781572
* [MethodCalls.fs] Defining CallerArgs<'T> in, this replaces passing …
smoothdeveloper Apr 22, 2019
81ef5f2
bit of refactoring of error message building logic during failed over…
smoothdeveloper Apr 23, 2019
69cbc05
(buildfix) harmonizing .fsi/.fs right before commit doesn't always wo…
smoothdeveloper Apr 23, 2019
9f47fee
trying to check what kind of things break loose when I change this
smoothdeveloper Apr 24, 2019
41b219c
(minor) [ConstraintSolver.fs] revert space mishapps to reduce diff, p…
smoothdeveloper Apr 24, 2019
7f73826
toward displaying the argument names properly (may fail some fsharpqa…
smoothdeveloper Apr 24, 2019
0904de6
missing Resharper's Ctrl+Alt+V "introduce variable" refactoring @audu…
smoothdeveloper Apr 24, 2019
f1eadef
pretty print unresolved overloads without all the type submsumption p…
smoothdeveloper Apr 25, 2019
9eb633a
Overload resolution error messages: things display like I want in fsi…
smoothdeveloper Apr 25, 2019
b49d285
adjust message for candidates overload
smoothdeveloper Apr 26, 2019
6aaf2dd
Hijack the split phase for UnresolvedOverloading, remove the match on…
smoothdeveloper Apr 29, 2019
f66e082
updating existing failing baseline files that looks correct to me
smoothdeveloper Apr 29, 2019
3f03717
quickfix for update.base.line.with.actuals.fsx so that it skips missi…
smoothdeveloper Apr 29, 2019
389a804
(minor) minimize diff, typos, comments
smoothdeveloper Apr 30, 2019
dbe7a37
fix vsintegration tests affected by overload error message changes
smoothdeveloper Apr 30, 2019
f8e7428
merge issue unused variable warning
smoothdeveloper Apr 30, 2019
c51e25c
update the 12 fsharpqa migrated baseline with new error messages
smoothdeveloper Apr 30, 2019
41f57e1
(minor) baseline update script
smoothdeveloper Apr 30, 2019
51e3a0e
move System.Convert.ToString and System.Threading.Tasks.Task.Run test…
smoothdeveloper Apr 30, 2019
76c9c59
* moving 3 fsharpqa tests to new test suite
smoothdeveloper May 2, 2019
b00175f
consolidate all string building logic in CompileOps.fs, fix remaining…
smoothdeveloper May 2, 2019
e64f4f6
update base lines
smoothdeveloper May 2, 2019
db5df8d
remove the migrated tests from fsharpqa
smoothdeveloper May 2, 2019
dce9b92
fix vstest error message
smoothdeveloper May 2, 2019
36b6a13
fix env.lst, removed wrong one...
smoothdeveloper May 2, 2019
bf4ee09
update baselines of remaining tests
smoothdeveloper May 2, 2019
f45a218
adding one simple test with many overloads
smoothdeveloper May 2, 2019
ce65f30
appropriate /// comments on `CalledMeth` constructor arguments
smoothdeveloper May 2, 2019
372a375
minimize diff / formatting
smoothdeveloper May 2, 2019
db26509
trim unused code
smoothdeveloper May 2, 2019
46174af
add simple test, one message is interesting, mentioning parameter cou…
smoothdeveloper May 3, 2019
c2120f6
comment flaky test for now
smoothdeveloper May 3, 2019
ec6089c
code review on the `coerceExpr` function from @tihan, we can discard …
smoothdeveloper May 8, 2019
4f51ad4
code formatting remarks on ConstraintSolver.fs/fsi
smoothdeveloper May 14, 2019
2d27e63
(minor) formatting
smoothdeveloper May 14, 2019
28f46ca
format known argument type / updating .bsl
smoothdeveloper May 16, 2019
20abb54
update missing baseline
smoothdeveloper May 16, 2019
c5de0ac
update missing baselines
smoothdeveloper May 16, 2019
e08db81
update missing baseline
smoothdeveloper May 16, 2019
628d8bc
minor: make TTrait better in debugger display
smoothdeveloper Aug 24, 2019
e2bc962
[wip] pass TraitConstraintInfo around failed overload resolution erro…
smoothdeveloper Aug 24, 2019
4f70822
minimize diff
smoothdeveloper Aug 27, 2019
138267f
signature file mismatch
smoothdeveloper Aug 27, 2019
ebf60fa
removing duplicate in fscomp.txt
smoothdeveloper Dec 27, 2019
20a4cff
surfacing initial bits of TraitConstraintInfo, roughly for now
smoothdeveloper Dec 27, 2019
5bb714a
formatting types of known argument in one go, the formatting is still…
smoothdeveloper Jan 12, 2020
59f82b1
rework of overload failure message to prettify *ALL* types in a singl…
smoothdeveloper Jan 15, 2020
7b8fdfc
fixup the tests and add two tests
smoothdeveloper Jan 15, 2020
a956bce
updating baselines that got tighter.
smoothdeveloper Jan 16, 2020
8b102a0
simplify handling of TraitConstraintInfo
smoothdeveloper Jan 16, 2020
8543f80
naming couple of fields and turning a property to a methods as it tri…
smoothdeveloper Jan 17, 2020
c5739e7
comments in the assembling of overload resolution error message
smoothdeveloper Jan 17, 2020
ade30f5
Add information about which argument doesn't match
smoothdeveloper Jan 19, 2020
207a584
minor updates to testguide and devguide
smoothdeveloper Jan 19, 2020
7ca85af
fix PrimitiveConstraints.``Invalid object constructor`` test
smoothdeveloper Jan 19, 2020
723a293
fix(?) salsa tests
smoothdeveloper Jan 19, 2020
f0be1bb
minimize diff
smoothdeveloper Jan 19, 2020
373f0f3
put back tests under !FSHARP_SUITE_DRIVES_CORECLR_TESTS
smoothdeveloper Jan 19, 2020
4c7d525
missing updated message
smoothdeveloper Jan 19, 2020
5408e4f
minor adjustments to TESTGUIDE.md
smoothdeveloper Jan 19, 2020
e8dc47b
return type was missing prettifying in prettyLayoutsOfUnresolvedOverl…
smoothdeveloper Jan 19, 2020
99097a6
address code review nits / minimize diff / add comment on PrettifyDis…
smoothdeveloper Jan 22, 2020
99c1230
minimize diff
smoothdeveloper Jan 22, 2020
9f20d8f
proposed work around the flaky error message until https://github.com…
smoothdeveloper Jan 22, 2020
45be9dc
fixing baselines of new tests from master
smoothdeveloper Jan 22, 2020
18cbe3c
sisyphus round of baseline update
smoothdeveloper Jan 22, 2020
c7d8b13
removing type which isn't in use and popped back up after rebase
smoothdeveloper Jan 22, 2020
209cc6c
minimize diff
smoothdeveloper Jan 23, 2020
1f17d51
tidy inconsistent tuple literal
smoothdeveloper Jan 23, 2020
90defce
* removing TTrait properties that end up not being used
smoothdeveloper Jan 23, 2020
d99015f
minimize diff
smoothdeveloper Jan 23, 2020
3176d37
minimize diff
smoothdeveloper Jan 23, 2020
97ebec3
minimize diff
smoothdeveloper Jan 23, 2020
61478c2
link to usage example in same file
smoothdeveloper Jan 24, 2020
304f505
revert converting CallerArg single cased DU into Record
smoothdeveloper Jan 29, 2020
4352bad
minimize diff
smoothdeveloper Jan 29, 2020
f18a205
minimize diff
smoothdeveloper Jan 29, 2020
7cf610d
minimize diff
smoothdeveloper Jan 29, 2020
5eff584
fix rebase glitches
smoothdeveloper Feb 15, 2020
0d99fef
fix rebase glitch
smoothdeveloper Feb 15, 2020
95fe837
update baseline
smoothdeveloper Feb 15, 2020
4141681
fix base lines / new tests base lines
smoothdeveloper Feb 15, 2020
3042bda
edge case: needs a new line after "A unique overload for method '%s' …
smoothdeveloper Feb 15, 2020
e03f680
updating base line for edge case of missing new line
smoothdeveloper Feb 15, 2020
1b0530d
missing baseline
smoothdeveloper Feb 15, 2020
9ab9ea9
removing comment
smoothdeveloper Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
trim unused code
  • Loading branch information
@smoothdeveloper
smoothdeveloper committed Feb 15, 2020
commit db26509dc979ab65d59a7ff3485da98158c89aaa
2 changes: 0 additions & 2 deletions src/fsharp/CompileOps.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ let GetRangeOfDiagnostic(err: PhasedDiagnostic) =
| NameClash(_, _, _, m, _, _, _)
| UnresolvedOverloading(_, _, _, m)
| UnresolvedConversionOperator (_, _, _, m)
| PossibleOverload(_, _, m)
| VirtualAugmentationOnNullValuedType m
| NonVirtualAugmentationOnNullValuedType m
| NonRigidTypar(_, _, _, _, _, m)
Expand Down Expand Up @@ -449,7 +448,6 @@ let ErrorFromApplyingDefault2E() = DeclareResourceString("ErrorFromApplyingDefau
let ErrorsFromAddingSubsumptionConstraintE() = DeclareResourceString("ErrorsFromAddingSubsumptionConstraint", "%s%s%s")
let UpperCaseIdentifierInPatternE() = DeclareResourceString("UpperCaseIdentifierInPattern", "")
let NotUpperCaseConstructorE() = DeclareResourceString("NotUpperCaseConstructor", "")
let PossibleOverloadE() = DeclareResourceString("PossibleOverload", "%s%s")
let FunctionExpectedE() = DeclareResourceString("FunctionExpected", "")
let BakedInMemberConstraintNameE() = DeclareResourceString("BakedInMemberConstraintName", "%s")
let BadEventTransformationE() = DeclareResourceString("BadEventTransformation", "")
Expand Down
2 changes: 0 additions & 2 deletions src/fsharp/ConstraintSolver.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
module internal FSharp.Compiler.ConstraintSolver

open Internal.Utilities.Collections
open Internal.Utilities.StructuredFormat

open FSharp.Compiler
open FSharp.Compiler.AbstractIL
Expand Down Expand Up @@ -215,7 +214,6 @@ exception ErrorFromAddingTypeEquation of tcGlobals: TcGlobals * displayEnv: Disp

exception ErrorsFromAddingSubsumptionConstraint of tcGlobals: TcGlobals * displayEnv: DisplayEnv * TType * TType * exn * ContextInfo * range
exception ErrorFromAddingConstraint of displayEnv: DisplayEnv * exn * range
exception PossibleOverload of displayEnv: DisplayEnv * overload: OverloadInformation * range
exception UnresolvedOverloading of displayEnv: DisplayEnv * callerArgs: CallerArgs<Expr> * failure: OverloadResolutionFailure * range
exception UnresolvedConversionOperator of displayEnv: DisplayEnv * TType * TType * range

Expand Down
1 change: 0 additions & 1 deletion src/fsharp/ConstraintSolver.fsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ exception ErrorFromAddingTypeEquation of tcGlobals: TcGlobals * displa
exception ErrorsFromAddingSubsumptionConstraint of tcGlobals: TcGlobals * displayEnv: DisplayEnv * TType * TType * exn * ContextInfo * range
exception ErrorFromAddingConstraint of displayEnv: DisplayEnv * exn * range
exception UnresolvedConversionOperator of displayEnv: DisplayEnv * TType * TType * range
exception PossibleOverload of displayEnv: DisplayEnv * overload: OverloadInformation * range
exception UnresolvedOverloading of displayEnv: DisplayEnv * callerArgs: CallerArgs<Expr> * failure: OverloadResolutionFailure * range
exception NonRigidTypar of displayEnv: DisplayEnv * string option * range * TType * TType * range

Expand Down