fix anon recd creation bug (#6434) #6619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
approved these changes
Apr 23, 2019
KevinRansom
approved these changes
Apr 24, 2019
Contributor
|
@cartermp Do you know which version of .NET Core this fix was rolled out with? |
Contributor
|
@isaacabraham It's available in the latest preview, but other than that, no. We don't manually insert our compiler into the SDK anymore, so the answer to questions like this is generally, "when it undergoes automatic dependency update". |
Contributor
|
It is in branch 16.3, so the preview for VS2019.3 should have it: |
Contributor
|
Thanks both. I'm asking because I have that fix but someone else on the team doesn't - I have latest VS2019 update and NET Core 3 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6434
We were missing the creation of anonymous records if they didn't appear in a type signature anywhere
Also make anonymous record generation slightly simpler and more efficient.