Skip to content

re-enable code for .NET Core FSI #6620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 1 commit into from
Apr 24, 2019
Merged

re-enable code for .NET Core FSI #6620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/absil/ilreflect.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2003,9 +2003,6 @@ let createTypeRef (visited: Dictionary<_, _>, created: Dictionary<_, _>) emEnv t
visited.[tref] <- true
let tdef = envGetTypeDef emEnv tref
if verbose2 then dprintf "- traversing type %s\n" typB.FullName
#if FX_NO_APP_DOMAINS
traverseTypeDef tref tdef
#else
// This looks like a special case (perhaps bogus) of the dependency logic above, where
// we require the type r.Name, though with "nestingToProbe" being the enclosing types of the
// type being defined.
Expand All @@ -2029,7 +2026,7 @@ let createTypeRef (visited: Dictionary<_, _>, created: Dictionary<_, _>) emEnv t
traverseTypeDef tref tdef
finally
System.AppDomain.CurrentDomain.remove_TypeResolve typeCreationHandler
#endif

// At this point, we've done everything we can to prepare the type for loading by eagerly forcing the
// load of other types. Everything else is up to the implementation of System.Reflection.Emit.
if not (created.ContainsKey tref) then
Expand Down