Changed cancellation strategy for project options #6723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
reviewed
May 13, 2019
| try | ||
| // For now, disallow miscellaneous workspace since we are using the hacky F# miscellaneous files project. | ||
| if document.Project.Solution.Workspace.Kind = WorkspaceKind.MiscellaneousFiles then | ||
| reply.Reply(None) |
Contributor
There was a problem hiding this comment.
nit braces. and 2 below
KevinRansom
reviewed
May 13, 2019
| } | ||
|
|
||
| let rec tryComputeOptions (project: Project) (cancellationToken: CancellationToken) = | ||
| let rec tryComputeOptions (project: Project) = |
Contributor
There was a problem hiding this comment.
Is the comment:
// Because this code can be kicked off before the hack, HandleCommandLineChanges, occurs,
still valid?
KevinRansom
reviewed
May 13, 2019
| try | ||
| // For now, disallow miscellaneous workspace since we are using the hacky F# miscellaneous files project. | ||
| if document.Project.Solution.Workspace.Kind = WorkspaceKind.MiscellaneousFiles then | ||
| if cancellationToken.IsCancellationRequested then |
Contributor
There was a problem hiding this comment.
It seems as if cancellationToken is no longer passed in as an argument to tryComputeOptions so for my education where does this come from?
Contributor
Author
There was a problem hiding this comment.
We need to pass the CT to calls to grab textversion and text. I should not have removed it.
KevinRansom
approved these changes
May 13, 2019
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Looks good to me ... nice work.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Trying to fix script performance * Changed cancellation strategy * Added back cancellationToken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve some of the performance issues that we saw in scripts, #6250 .
We still have an issue with UI delays in the example presented by @kevmal , but it should be a lot better. I need to look into the UI delays more and figure out why that's happening.