Skip to content

Roslyn Shim - Round 2 #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettfo merged 23 commits into from
Jun 13, 2019
Merged

Roslyn Shim - Round 2 #6734

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8a39f54
Added shims over document diagnostic analyzers
TIHan May 7, 2019
089d60c
Shims over completions and sig help
TIHan May 8, 2019
aefc92e
Removed content type definitions, putting them in external access
TIHan May 8, 2019
9f8ec0b
Added shim over InlineRenameService
TIHan May 8, 2019
39d88b5
We are now simply using export on the diagnostic analyzers
TIHan May 8, 2019
5924f70
Using shim for document highlights service
TIHan May 8, 2019
acbe40a
GoToDefinition implemented with shims
TIHan May 26, 2019
471e4d3
NavigableSymbolsService shimmed
TIHan May 26, 2019
40b8b2d
GoToDefinitionService shimmed
TIHan May 26, 2019
53c0461
NavigationBarItemService shimmmed
TIHan May 26, 2019
78663ae
Shimmed NavigateToSearchService
TIHan May 26, 2019
540d30d
Quick cast fix
TIHan May 26, 2019
f45d179
Using FSharpGlyphTags
TIHan May 26, 2019
0d24cab
Removed CommentSelectionService as it is ExternalAccess now
TIHan May 26, 2019
f07a689
Shimmed BlockStructureService
TIHan May 26, 2019
8a30a1d
Trying to finish shim
TIHan May 26, 2019
eb0b351
Merge branch 'release/dev16.2' into roslyn-shim-v2
TIHan May 26, 2019
b338bd7
Removed folder from FSharp.Editor
TIHan May 28, 2019
53aa912
Update package
TIHan Jun 12, 2019
cf35794
merging latest
TIHan Jun 12, 2019
1104891
fixing build
TIHan Jun 12, 2019
2fef9b5
Trying to fix build
TIHan Jun 12, 2019
55953d2
match roslyn package version
brettfo Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Using FSharpGlyphTags
  • Loading branch information
@TIHan
TIHan committed May 26, 2019
commit f45d179bc7d83397baec5fedb4dbc4a35431ad6a
2 changes: 1 addition & 1 deletion vsintegration/src/FSharp.Editor/Navigation/FindUsagesService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ type internal FSharpFindUsagesService
let! symbol = Tokenizer.getSymbolAtPosition(document.Id, sourceText, position, document.FilePath, defines, SymbolLookupKind.Greedy, false)
let! symbolUse = checkFileResults.GetSymbolUseAtLocation(lineNumber, symbol.Ident.idRange.EndColumn, textLine, symbol.FullIsland, userOpName=userOpName)
let! declaration = checkFileResults.GetDeclarationLocation (lineNumber, symbol.Ident.idRange.EndColumn, textLine, symbol.FullIsland, false, userOpName=userOpName) |> liftAsync
let tags = GlyphTags.GetTags(Microsoft.CodeAnalysis.ExternalAccess.FSharp.FSharpGlyphHelpersObsolete.Convert(Tokenizer.GetGlyphForSymbol (symbolUse.Symbol, symbol.Kind)))
let tags = FSharpGlyphTags.GetTags(Tokenizer.GetGlyphForSymbol (symbolUse.Symbol, symbol.Kind))

let declarationRange =
match declaration with
Expand Down