Preview package #6761
Merged
Preview package #6761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
suggested changes
May 17, 2019
| <FSharpDesignTimeProtocol Condition = " '$(FSharpDesignTimeProtocol)' == '' ">fsharp41</FSharpDesignTimeProtocol> | ||
| <FSharpToolsDirectory Condition = " '$(FSharpToolsDirectory)' == '' ">tools</FSharpToolsDirectory> | ||
| </PropertyGroup> | ||
| </PropertyGroup> |
| <trans-unit id="fSharpBannerVersion"> | ||
| <source>{0} for F# {1}</source> | ||
| <target state="new">{0} for F# {1}</target> | ||
| <note /> |
Member
There was a problem hiding this comment.
Might want to change this to: <note>Contains version numbers. E.g., '10.4.3 for F# 4.6'</note> so the translators know what's happening.
Contributor
Author
There was a problem hiding this comment.
I like that … good idea.
Contributor
Author
There was a problem hiding this comment.
I tried it, and the note I had added got overwritten.
brettfo
approved these changes
May 20, 2019
cartermp
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to the project file this property:
The build will pick up the latest preview file published to myget.