Skip to content

Removed reference counting from IncrementalBuilder; now relies on GC. #6863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 11 commits into from
May 31, 2019
Merged

Removed reference counting from IncrementalBuilder; now relies on GC. #6863

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cc41ebe
TcImports doesn't explicitly have to be disposed, relies on GC. Remov…
TIHan May 23, 2019
5779215
Removing any notion of being incremental builder reference counting a…
TIHan May 24, 2019
9251353
Added ITypeProviderThread
TIHan May 25, 2019
b3d0b38
Fixed declaration list item
TIHan May 25, 2019
fb8ecf7
Changed EnqueueWorkAndWait to just EnqueueWork that's not blocking
TIHan May 25, 2019
84308e5
Minor cleanup
TIHan May 25, 2019
2a693f8
Forgot to check disposed
TIHan May 25, 2019
05b7d39
Quick update on comment
TIHan May 25, 2019
e11699d
Update FCS project
TIHan May 25, 2019
a6c6306
Renamed ITypeProviderThread to ICompilationThread
TIHan May 30, 2019
0262e2d
Changes from feedback and added a test
TIHan May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Forgot to check disposed
  • Loading branch information
@TIHan
TIHan committed May 25, 2019
commit 2a693f873780a003a3f9b03a5049ccae96b354fe
4 changes: 3 additions & 1 deletion src/fsharp/CompileOps.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3848,7 +3848,9 @@ and [<Sealed>] TcImports(tcConfigP: TcConfigProvider, initialResolutions: TcAsse
dllTable

#if !NO_EXTENSIONTYPING
member tcImports.Weak = tcImportsWeak
member tcImports.Weak =
CheckDisposed()
tcImportsWeak
#endif

member tcImports.RegisterCcu ccuInfo =
Expand Down