Skip to content

Remove call to internal API in Simplify Name Analyzer #6901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 2 commits into from
May 31, 2019
Merged

Remove call to internal API in Simplify Name Analyzer #6901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daa190d
Remove call to internal API in Simplify Name Analyzer
cartermp May 29, 2019
d6a18cf
Remove unused opens
cartermp May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions vsintegration/src/FSharp.Editor/Diagnostics/SimplifyNameDiagnosticAnalyzer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@ open System.Collections.Immutable
open System.Diagnostics
open System.Threading
open System.Threading.Tasks
open System.Runtime.CompilerServices

open Microsoft.CodeAnalysis
open Microsoft.CodeAnalysis.Diagnostics
open FSharp.Compiler
open FSharp.Compiler.Range
open FSharp.Compiler.SourceCodeServices
open System.Runtime.Caching
open Microsoft.CodeAnalysis.ExternalAccess.FSharp.Diagnostics

Expand Down Expand Up @@ -94,7 +92,7 @@ type internal SimplifyNameDiagnosticAnalyzer() =
match rest with
| [] -> return current
| headIdent :: restPlid ->
let! res = checkResults.IsRelativeNameResolvable(posAtStartOfName, current, symbolUse.Symbol.Item, userOpName=userOpName)
let! res = checkResults.IsRelativeNameResolvableFromSymbol(posAtStartOfName, current, symbolUse.Symbol, userOpName=userOpName)
if res then return current
else return! loop restPlid (headIdent :: current)
}
Expand Down