Replace FSComp invocations in VS tooling with an FCS API #6904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
reviewed
May 31, 2019
| namespace FSharp.Compiler.SourceCodeServices | ||
|
|
||
| /// Supported kinds of diagnostics by this service. | ||
| type DiagnosticKind = |
Contributor
There was a problem hiding this comment.
@cartermp,
Are there other scenarios, where a developer wants to get a string from the compiler.private dll? or are they all diagnostic? Should the Api be named more generaly. Or will the non diagnostic scenarios, expose new modules?
Thanks
kevin
Contributor
Author
There was a problem hiding this comment.
I imagine I'd have a new ServiceFoo file that services up the Foo stuff from the compiler of the need arises.
KevinRansom
approved these changes
Jun 1, 2019
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another round of cleaning upon removing the IVT into FSharp.Editor.