remove NuGet dependency from fslex/fsyacc #6913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #6912 the implicit NuGet reference to the FSharp.Core package needs to be removed from
fslex.fsprojandfsyacc.fsproj. Our two options were to either try to steal theFSharp.Core.dllthat's next to the running compiler, or pre-buildFSharp.Core.fsproj. I opted for the latter because the first option seemed very prone to failure, and while there has been support in the past forfsc.exeto magically provide anFSharp.Core.dll, I think we'd be better served getting out of the business of implicit binary references, especially with the possibility that the LKG compiler (and therefore it'sFSharp.Core.dll) andfslex.dllmight not target the same TFM. While the path I took increases the initial build time, the TFM/platform will always be correct, it should be more stable and easier to diagnose any failures that may arise.Fixes #6912.