Use LangVersion on 'Add missing case for underscore in for _ =' #6931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
langvalMissingCase
branch
3 times, most recently
from
22a6656 to
218ca54
Compare
KevinRansom
force-pushed
the
langvalMissingCase
branch
from
218ca54 to
d680c0c
Compare
brettfo
suggested changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6867
This makes this recently merged file respond to the langversion flag.
This PR builds on the unmergedPR: "Ensure that Language Version support flows to Parser"
#6891
The commit to review is the most recent. 51538fd
a. When langVersion is 4.6, we get the error
b. When langVersion is 4.7 or above it succeeds