Stop calling GetHierarchy in FSharpProjectOptionsReactor #6946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Jun 6, 2019
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Looks good overall, just a question
|
|
||
| [<Sealed>] | ||
| type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspace, settings: EditorOptions, serviceProvider, checkerProvider: FSharpCheckerProvider) = | ||
| type private FSharpProjectOptionsReactor (_workspace: VisualStudioWorkspace, settings: EditorOptions, _serviceProvider, checkerProvider: FSharpCheckerProvider) = |
Contributor
There was a problem hiding this comment.
Are these unused values needed as parameters given the _?
Contributor
Author
There was a problem hiding this comment.
They are unused for now, they will be used when I start doing more refactoring here.
Contributor
|
It got us again 😄
|
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Stop calling GetHierarchy in FSharpProjectOptionsReactor * Fixing build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves this issue: #6940
Basically we stop calling
workspace.GetHierarchyin the background for computing F# project options; we can simply just pass the legacy project'sIProjectSitedirectly to the F# project options manager instead of relying on the workspace to get it throughIVsHierarchy.