Skip to content

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Jun 7, 2019

I think this document is outdated and duplicating too much information at this point. I also think most people don't read it or know it even exists. In an effort to simplify the amount of documents we either explicitly or implicitly expect people to read, I think this can be removed.

I think this document is outdated and duplicating too much information at this point. I also think most people don't read it or know it even exists. In an effort to simplify the amount of documents we either explicitly or implicitly expect people to read, I think this can be removed.
@cartermp cartermp mentioned this pull request Jun 7, 2019
@tannergooding
Copy link
Member

@cartermp, this should be fine provided the guidelines are in the README.md instead.

I can send you a link to the guidance (which is internal), but it currently states the following as being "required".

The process for contributing is clearly documented in the README.md or CONTRIBUTING.md.

@cartermp
Copy link
Contributor Author

cartermp commented Jun 7, 2019

@tannergooding We provide a quickstart in the README and link to the DEVGUIDE.md file that contains all the relevant information about developing various parts of the repo.

@voronoipotato
Copy link
Contributor

Contributing.md seems to be a much more consistent pattern in development repos, perhaps we should rename DEVGUIDE.md to CONTRIBUTING.md

@voronoipotato
Copy link
Contributor

voronoipotato commented Jun 10, 2019

CLA

Contributors are required to sign a Contribution License Agreement (CLA) before any pull requests will be considered. After submitting a request via the provided form, electronically sign the CLA when you receive the email containing the link to the document. This only needs to be done once for each Microsoft OSS project you contribute to.

Coding guidelines

Although there is currently no strict set of coding or style guidelines, use common sense when contributing code - make an effort to use a similar style to nearby existing code. If you have a passion for helping us develop a set of coding guidelines that we can roll out and apply within this project, get involved and start a discussion issue.

These may be also useful.

@cartermp cartermp merged commit 49082d3 into master Jun 10, 2019
@cartermp cartermp deleted the cartermp-patch-1 branch June 10, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants