Remove IVTs to legacy language service

src/fsharp/FSharp.Compiler.Private/FSharp.Compiler.Private.fsproj

@@ -40,8 +40,6 @@
 
   <ItemGroup>
     <InternalsVisibleTo Include="fsc" />
-    <InternalsVisibleTo Include="FSharp.LanguageService" />
-    <InternalsVisibleTo Include="FSharp.LanguageService.Base" />
     <InternalsVisibleTo Include="FSharp.ProjectSystem.Base" />
     <InternalsVisibleTo Include="FSharp.ProjectSystem.FSharp" />
     <InternalsVisibleTo Include="FSharp.ProjectSystem.PropertyPages" />

vsintegration/src/FSharp.LanguageService/GotoDefinition.fs

@@ -5,23 +5,27 @@
 namespace Microsoft.VisualStudio.FSharp.LanguageService
 
 open System
-open System.IO
-open System.Collections.Generic
 open System.Diagnostics
 open Microsoft.VisualStudio
-open Microsoft.VisualStudio.Shell
-open Microsoft.VisualStudio.Shell.Interop 
 open Microsoft.VisualStudio.TextManager.Interop 
 open FSharp.Compiler
-open FSharp.Compiler.Lib
 open FSharp.Compiler.SourceCodeServices
 
+/// Contains the value this dead code uses from the internals of the parser.
+/// Now this value is just a constant here; as the actual tag value is unlikely to ever change, and this entire file is dead code only active in legacy tests that we have yet to migrate.
+module Constants =
+    [<Literal>]
+    let Parse_Ident_Tag_Value = 190
+
 module internal OperatorToken =
 
     let asIdentifier_DEPRECATED (token : TokenInfo) =
         // Typechecker reports information about all values in the same fashion no matter whether it is named value (let binding) or operator
         // here we piggyback on this fact and just pretend that we need data time for identifier
-        let tagOfIdentToken = FSharp.Compiler.Parser.tagOfToken(FSharp.Compiler.Parser.IDENT "")
+
+        // Dead code (aside from legacy tests), ignore
+        let tagOfIdentToken = Constants.Parse_Ident_Tag_Value
+
         let endCol = token.EndIndex + 1 // EndIndex from GetTokenInfoAt points to the last operator char, but here it should point to column 'after' the last char 
         tagOfIdentToken, token.StartIndex, endCol
 
@@ -69,7 +73,9 @@ module internal GotoDefinition =
                 |> GotoDefinitionResult_DEPRECATED.MakeError
             | Some(colIdent, tag, qualId) ->
                 if typedResults.HasFullTypeCheckInfo then 
-                    if Parser.tokenTagToTokenId tag <> Parser.TOKEN_IDENT then 
+                    // Used to be the Parser's internal definition, now hard-coded to avoid an IVT into the parser itsef.
+                    // Dead code (aside from legacy tests), ignore
+                    if tag <> Constants.Parse_Ident_Tag_Value then
                         Strings.GotoDefinitionFailed_NotIdentifier()
                         |> GotoDefinitionResult_DEPRECATED.MakeError
                     else

vsintegration/src/FSharp.LanguageService/Intellisense.fs

@@ -224,7 +224,7 @@ type internal FSharpDeclarations_DEPRECATED(documentationBuilder, declarations:
         // We intercept this call only to get the initial extent
         // of what was committed to the source buffer.
         let result = decl.GetName(filterText, index)
-        FSharp.Compiler.Lexhelp.Keywords.QuoteIdentifierIfNeeded result
+        Keywords.QuoteIdentifierIfNeeded result
 
     override decl.IsCommitChar(commitCharacter) =
         // Usual language identifier rules...