Skip to content

cherrypick fix portable PDBs for anon records (#7099) #7208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 1 commit into from
Jul 12, 2019
Merged

cherrypick fix portable PDBs for anon records (#7099) #7208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/absil/ilwritepdb.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,12 +403,17 @@ let generatePortablePdb (embedAllSource: bool) (embedSourceList: string list) (s
if i < 1 || offsetDelta > 0 then
builder.WriteCompressedInteger offsetDelta

// Hidden-sequence-point-record
if startLine = 0xfeefee || endLine = 0xfeefee || (startColumn = 0 && endColumn = 0)
// Check for hidden-sequence-point-record
if startLine = 0xfeefee ||
endLine = 0xfeefee ||
(startColumn = 0 && endColumn = 0) ||
((endLine - startLine) = 0 && (endColumn - startColumn) = 0)
then
// Hidden-sequence-point-record
builder.WriteCompressedInteger 0
builder.WriteCompressedInteger 0
else // Non-hidden-sequence-point-record
else
// Non-hidden-sequence-point-record
let deltaLines = endLine - startLine // lines
builder.WriteCompressedInteger deltaLines

Expand Down