Skip to content

Check for exit code in compiler tests #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 1 commit into from
Jul 14, 2019
Merged

Check for exit code in compiler tests #7211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Check for exit code in compiler tests
  • Loading branch information
@forki
forki authored Jul 12, 2019
commit c930aa477fbd23ace7ff412dd57dfc05d4af5f05
3 changes: 3 additions & 0 deletions tests/fsharp/Compiler/CompilerAssert.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,9 @@ module CompilerAssert =
let errors = p.StandardError.ReadToEnd ()
if not (String.IsNullOrWhiteSpace errors) then
Assert.Fail errors

if p.ExitCode <> 0 then
Assert.Fail(sprintf "Program exited with exit code %d" p.ExitCode)
Copy link
Contributor

@KevinRansom KevinRansom Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to see the program and arguments here as well. That may make it easier to diagnose the error?

)

let CompileLibraryAndVerifyIL (source: string) (f: ILVerifier -> unit) =
Expand Down