Skip to content

FSharp.Compiler.Private only targets netstandard2.0 #7220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cartermp wants to merge 64 commits into from
Closed

FSharp.Compiler.Private only targets netstandard2.0 #7220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
85f4c50
Copy sources from Versions.props to NuGet.config (#7191)
Jul 11, 2019
5f1a882
Only check distinct errors (#7140)
forki Jul 11, 2019
d5ae449
Use 1-based column numbers in tests (#7141)
forki Jul 11, 2019
7d95349
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Jul 11, 2019
ef339d5
wip
cartermp Jul 12, 2019
04c8453
wip
cartermp Jul 12, 2019
72812eb
WIP
cartermp Jul 12, 2019
7043092
Feedback
cartermp Jul 22, 2019
fad8d87
progress
cartermp Jul 22, 2019
c76f6be
simplify defineconstants
cartermp Jul 22, 2019
b79635f
More progress
cartermp Jul 22, 2019
acedd56
no FS_RESHAPED_REFLECTION
cartermp Aug 16, 2019
cc01140
more remove FX_RESHAPED_REFLECTION
cartermp Aug 16, 2019
5b0bb1e
fixing stuff
cartermp Aug 17, 2019
0bf7295
more
cartermp Aug 17, 2019
0417edf
doopty
cartermp Aug 17, 2019
a88058e
Merge branch 'release/fsharp47' into netstandard-fcp
cartermp Aug 17, 2019
7f56757
Update common-variables.yml
cartermp Aug 17, 2019
c54e3fe
Update common-variables.yml
cartermp Aug 17, 2019
5390499
Update illib.fs
cartermp Aug 17, 2019
64fa173
Update illib.fs
cartermp Aug 17, 2019
ad9cd1d
Update prim-types.fs
cartermp Aug 17, 2019
b7d459c
Update quotations.fs
cartermp Aug 17, 2019
b3a8c11
Update reflect.fs
cartermp Aug 17, 2019
8182731
Update seq.fs
cartermp Aug 17, 2019
67e833a
Update sformat.fs
cartermp Aug 17, 2019
fb96871
Update sformat.fs
cartermp Aug 17, 2019
b485292
Update sformat.fsi
cartermp Aug 17, 2019
8b87490
Update sformat.fs
cartermp Aug 17, 2019
9d326fa
Update FSharpReflection.fs
cartermp Aug 17, 2019
db858bf
Update LibraryTestFx.fs
cartermp Aug 17, 2019
fe5a393
Update LibraryTestFx.fs
cartermp Aug 17, 2019
e554f51
Update test.fsx
cartermp Aug 17, 2019
3494619
Update FSharp.Profiles.props
cartermp Aug 17, 2019
cb5eafc
Update FSharp.Compiler.Private.fsproj
cartermp Aug 17, 2019
e3dcfb2
tryit
cartermp Aug 19, 2019
23ec070
nope
cartermp Aug 19, 2019
e7b8380
try it
cartermp Aug 19, 2019
1250697
Print the value for now
cartermp Aug 20, 2019
dfc9c88
Print the value for now
cartermp Aug 20, 2019
5620512
Try emulating build-utils.ps1
cartermp Aug 20, 2019
bed411b
maybe this
cartermp Aug 20, 2019
fce2bfb
Add /bl maybe idk
cartermp Aug 20, 2019
ec6d4ca
get log with no changes to MSBuild shell out
cartermp Aug 20, 2019
5c9118a
derp
cartermp Aug 20, 2019
b96429f
Remove seemingly useless TargetFrameworkS
cartermp Aug 20, 2019
9ae3d66
let's try this
cartermp Aug 20, 2019
52879b2
whatever
cartermp Aug 20, 2019
327e818
lol if this works
cartermp Aug 20, 2019
679eb49
thought so
cartermp Aug 20, 2019
ea5c870
.
cartermp Aug 20, 2019
deee135
.
cartermp Aug 20, 2019
9031d37
tryit
cartermp Aug 20, 2019
7a047a2
revert
cartermp Aug 20, 2019
8446c3e
jojo
cartermp Aug 20, 2019
e1c98b4
jotaru
cartermp Aug 20, 2019
029f479
joseph joestar
cartermp Aug 20, 2019
dfca2e5
closer, based joseph
cartermp Aug 20, 2019
3808796
it's okay joseph, I got you bae
cartermp Aug 20, 2019
83232ab
hahahahahaha
cartermp Aug 20, 2019
df0c689
c'mon jojo
cartermp Aug 20, 2019
aa471cb
Set possibly null value to empty so we get better failures in the reg…
cartermp Aug 20, 2019
2a454da
build log not needed
cartermp Aug 21, 2019
64127c9
Update build.sh
cartermp Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
closer, based joseph
  • Loading branch information
@cartermp
cartermp committed Aug 20, 2019
commit dfca2e58dd13b6c8b95356f94bdf59edeb11a29b
13 changes: 4 additions & 9 deletions proto.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,10 @@
</PropertyGroup>

<ItemGroup>
<Projects Include="src\fsharp\FSharp.Build\FSharp.Build.fsproj">
<!-- <AdditionalProperties Condition="'$(OS)' == 'Unix'">TargetFramework=netcoreapp2.1</AdditionalProperties> -->
</Projects>
<Projects Include="src\fsharp\fsc\fsc.fsproj">
<!-- <AdditionalProperties Condition="'$(OS)' == 'Unix'">TargetFramework=netcoreapp2.1</AdditionalProperties> -->
</Projects>
<Projects Include="src\fsharp\fsi\fsi.fsproj">
<!-- <AdditionalProperties Condition="'$(OS)' == 'Unix'">TargetFramework=netcoreapp2.1</AdditionalProperties> -->
</Projects>
<Projects
Include="src\fsharp\FSharp.Build\FSharp.Build.fsproj"
Include="src\fsharp\fsc\fsc.fsproj"
Include="src\fsharp\fsi\fsi.fsproj" />
</ItemGroup>

<Target Name="Build">
Expand Down
8 changes: 8 additions & 0 deletions src/buildtools/AssemblyCheck/AssemblyCheck.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ module AssemblyCheck =
else
printfn "All shipping assemblies had an appropriate version number."

printfn "\n\n\n----------BEGIN JOSEPH JOESTAR----------\n"

printfn "F# Assmeblies:\n%A" fsharpAssemblies
printfn "F# Assmeblies filtered:\n%A" (fsharpAssemblies |> List.filter (fun p -> not (p.Contains(@"\FSharpSdk\")))


printfn "\n\n\n----------END JOSEPH JOESTAR----------\n"

// verify that all assemblies have a commit hash
let failedCommitHash =
fsharpAssemblies
Expand Down