Skip to content

fixes issue #6832 #7259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 10 commits into from
Jul 25, 2019
Merged

fixes issue #6832 #7259

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cdbfbdc
fixes issue #6832
KevinRansom Jul 20, 2019
8ad1412
Fix comment
KevinRansom Jul 20, 2019
ea3ef0b
Forgot to remove pdbs from fsharp.compiler.nuget
KevinRansom Jul 20, 2019
6ee93ea
Rename Program.fs and exclude FSharpSdk from checks
KevinRansom Jul 20, 2019
e724ecc
Embedded doesn't need to verify tmp or obj directories.
KevinRansom Jul 21, 2019
98947d8
typo
KevinRansom Jul 21, 2019
5b1a359
typo
KevinRansom Jul 21, 2019
831c120
Don't check FSharpSdk for hash
KevinRansom Jul 21, 2019
829fcf2
Make comment match code
KevinRansom Jul 22, 2019
41f3640
Empty commit to force rebuild
KevinRansom Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't check FSharpSdk for hash
  • Loading branch information
@KevinRansom
KevinRansom committed Jul 21, 2019
commit 831c1209a76bbd5919d191276ac87a7c0eaa3dba
1 change: 1 addition & 0 deletions src/buildtools/AssemblyCheck/AssemblyCheck.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ module AssemblyCheck =
// verify that all assemblies have a commit hash
let failedCommitHash =
fsharpAssemblies
|> List.filter (fun p -> not (p.Contains(@"\FSharpSdk\")))
|> List.filter (fun a ->
let fileProductVersion = FileVersionInfo.GetVersionInfo(a).ProductVersion
not (commitHashPattern.IsMatch(fileProductVersion) || devVersionPattern.IsMatch(fileProductVersion)))
Expand Down