Skip to content

Reneable warnexpressions tests #7331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 1 commit into from
Aug 2, 2019
Merged

Reneable warnexpressions tests #7331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Reneable warnexpressions tests
  • Loading branch information
@KevinRansom
KevinRansom committed Aug 2, 2019
commit 5eb66541068d8f4190326cabb3dc6532dd2c33d1
6 changes: 3 additions & 3 deletions tests/fsharp/Compiler/ErrorMessages/WarnExpressionTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ let changeX() =
(6, 5, 6, 15)
"The result of this equality expression has type 'bool' and is implicitly discarded. Consider using 'let' to bind the result to a name, e.g. 'let result = expression'."

// [<Test>] // Disable this test until we refactor tcImports and tcGlobals
[<Test>]
let ``Warn If Discarded In List``() =
CompilerAssert.TypeCheckWithErrorsAndOptions
[| "--langversion:4.6" |]
Expand All @@ -127,7 +127,7 @@ let view model dispatch =
"This expression returns a value of type 'int' but is implicitly discarded. Consider using 'let' to bind the result to a name, e.g. 'let result = expression'. If you intended to use the expression as a value in the sequence then use an explicit 'yield'."
|]

// [<Test>] // Disable this test until we refactor tcImports and tcGlobals
[<Test>]
let ``Warn If Discarded In List 2``() =
CompilerAssert.TypeCheckWithErrorsAndOptions
[| "--langversion:4.6" |]
Expand All @@ -154,7 +154,7 @@ let view model dispatch =
"This expression returns a value of type 'int list' but is implicitly discarded. Consider using 'let' to bind the result to a name, e.g. 'let result = expression'. If you intended to use the expression as a value in the sequence then use an explicit 'yield!'."
|]

// [<Test>] // Disable this test until we refactor tcImports and tcGlobals
[<Test>]
let ``Warn If Discarded In List 3``() =
CompilerAssert.TypeCheckWithErrorsAndOptions
[| "--langversion:4.6" |]
Expand Down