Skip to content

String map performance improvement #9470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 11 commits into from
Jun 27, 2020
Merged

String map performance improvement #9470

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9268073
Simplify and improve perf of String.length
abelbraaksma Jun 17, 2020
890ed1f
Improve performance of String.map
abelbraaksma Jun 17, 2020
10e5833
Revert "Simplify and improve perf of String.length"
abelbraaksma Jun 17, 2020
6c6b672
Resolves https://github.com/dotnet/fsharp/pull/9470#discussion_r44129…
abelbraaksma Jun 17, 2020
c054bb2
Lingering space
abelbraaksma Jun 17, 2020
e2cde1b
Change `String` to use `new` to clarify use of ctor
abelbraaksma Jun 17, 2020
b546153
Merge remote-tracking branch 'upstream/master' into String-map-perf
abelbraaksma Jun 17, 2020
332420e
Add some better tests for String.map, add side-effect test
abelbraaksma Jun 18, 2020
1b9bf85
Add tests to ensure the mapping function is called a deterministicall…
abelbraaksma Jun 18, 2020
0dd8922
Fix typo
abelbraaksma Jun 18, 2020
83ac13d
Remove "foo" from String.map tests
abelbraaksma Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Simplify and improve perf of String.length
  • Loading branch information
@abelbraaksma
abelbraaksma committed Jun 17, 2020
commit 92680733ef4001f908e80f36d9fea03cd9b08b4d
5 changes: 5 additions & 0 deletions FSharp.v3.ncrunchsolution.user
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<SolutionConfiguration>
<Settings>
<CurrentEngineMode>Run all tests automatically [Global]</CurrentEngineMode>
</Settings>
</SolutionConfiguration>
6 changes: 2 additions & 4 deletions src/fsharp/FSharp.Core/string.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,5 @@ namespace Microsoft.FSharp.Core

[<CompiledName("Length")>]
let length (str:string) =
if String.IsNullOrEmpty str then
0
else
str.Length
if isNull str then 0
else str.Length