Skip to content

Improve perf for String.filter up to 3x #9509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 4 commits into from
Jun 27, 2020
Merged

Improve perf for String.filter up to 3x #9509

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c0884b
Improve perf for String.filter 2-2.5x
abelbraaksma Jun 19, 2020
1577e1e
Cleanup: remove "foo" etc in tests
abelbraaksma Jun 19, 2020
ca0fadd
Add tests for new execution path for LOH in String.filter
abelbraaksma Jun 19, 2020
c7d4cda
Change test string
abelbraaksma Jun 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change test string
  • Loading branch information
@abelbraaksma
abelbraaksma committed Jun 20, 2020
commit c7d4cda9e8a22504e35e21228d1ed1601d5d131d
4 changes: 2 additions & 2 deletions tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Collections/StringModule.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ type StringModule() =
let e2 = String.filter (fun c -> true) null
Assert.AreEqual("", e2)

let e3 = String.filter (fun c -> c <> '\'') "Golliwog's cakewalk"
Assert.AreEqual("Golliwogs cakewalk", e3)
let e3 = String.filter Char.IsUpper "How Vexingly Quick Daft Zebras Jump!"
Assert.AreEqual("HVQDZJ", e3)

let e4 = String.filter (fun c -> c <> 'o') ""
Assert.AreEqual("", e4)
Expand Down