Skip to content

Perf: String.replicate from O(n) to O(log(n)), up to 12x speed improvement #9512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 6 commits into from
Jun 27, 2020
Merged

Perf: String.replicate from O(n) to O(log(n)), up to 12x speed improvement #9512

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9de8799
Turn String.replicate from O(n) into O(log(n))
abelbraaksma Jun 19, 2020
739fe30
Cleanup String.replicate tests by removing usages of "foo"
abelbraaksma Jun 19, 2020
9fdd920
String.replicate: add tests for missing cases, and for the new O(log(…
abelbraaksma Jun 19, 2020
02abc25
Improve String.replicate algorithm further
abelbraaksma Jun 20, 2020
d7f7387
Add tests for String.replicate covering all lines/branches of algo
abelbraaksma Jun 20, 2020
4f60f0b
Fix accidental comment
abelbraaksma Jun 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup String.replicate tests by removing usages of "foo"
  • Loading branch information
@abelbraaksma
abelbraaksma committed Jun 19, 2020
commit 739fe306999842817a8ce37bbf43449f3ab825c6
6 changes: 3 additions & 3 deletions tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Collections/StringModule.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ type StringModule() =

[<Test>]
member this.Replicate() =
let e1 = String.replicate 0 "foo"
let e1 = String.replicate 0 "Snickersnee"
Assert.AreEqual("", e1)

let e2 = String.replicate 2 "foo"
Assert.AreEqual("foofoo", e2)
let e2 = String.replicate 2 "Collywobbles, "
Assert.AreEqual("Collywobbles, Collywobbles, ", e2)

let e3 = String.replicate 2 null
Assert.AreEqual("", e3)
Expand Down