Fix issue with tests, see #9617 (#9622)

* Ignore NCrunch temp files and local user files

* Showing only failing line in ExprTests, cleanup temp files

* Show sensible message when UnresolvedPathReferenceNoRange is raised by tests

* Attempt to re-enable two base tests, may need to be re-disabled for Mono

* Cleanup tests that use global state, ensure deletion of temp files

* Fix difference Mono, fix spacing difference CI vs VS IDE

* Normalize null vs None

* Fix next issue difference between CI and local

* Make sure both smoke tests use the same filterhack function

* Next fix, overlooked

* Add procid and threadid to temp file

* Move #r System.Numerics to mkStandardProjectReferences

* Cleanup

* Fix tests that actually count references and are dependent on Common.fs

.gitignore

@@ -134,3 +134,7 @@ msbuild.binlog
 /tests/fsharp/regression/5531/compilation.output.test.txt
 /tests/fsharp/core/fsfromfsviacs/compilation.langversion.old.output.txt
 /tests/fsharp/core/fsfromfsviacs/compilation.errors.output.txt
+*ncrunch*.user
+_NCrunch_*
+.*crunch*.local.xml
+nCrunchTemp_*

src/fsharp/ErrorLogger.fs

@@ -91,7 +91,12 @@ exception PossibleUnverifiableCode of range
 
 exception UnresolvedReferenceNoRange of (*assemblyName*) string 
 exception UnresolvedReferenceError of (*assemblyName*) string * range
-exception UnresolvedPathReferenceNoRange of (*assemblyName*) string * (*path*) string
+exception UnresolvedPathReferenceNoRange of (*assemblyName*) string * (*path*) string with
+    override this.Message =
+        match this :> exn with
+        | UnresolvedPathReferenceNoRange(assemblyName, path) -> sprintf "Assembly: %s, full path: %s" assemblyName path
+        | _ -> "impossible"
+
 exception UnresolvedPathReference of (*assemblyName*) string * (*path*) string * range
 
 

tests/service/Common.fs

@@ -96,6 +96,7 @@ let mkStandardProjectReferences () =
             [ yield sysLib "mscorlib"
               yield sysLib "System"
               yield sysLib "System.Core"
+              yield sysLib "System.Numerics"
               yield fsCoreDefaultReference() ]
 #endif