Skip to content

Oops - I should have reviewed the original pr better ... sorry #9881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 4 commits into from
Aug 6, 2020
Merged

Oops - I should have reviewed the original pr better ... sorry #9881

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
755d2af
Fix Package Scripting nuget package
KevinRansom Aug 3, 2020
0b99f74
Merge branch 'master' of https://github.com/dotnet/fsharp
KevinRansom Aug 6, 2020
3f9fb4d
Compose
KevinRansom Aug 6, 2020
314019c
Phillip suggested options should compose too
KevinRansom Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/FSharp.Test.Utilities/Compiler.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,12 @@ module rec Compiler =

let withOptions (options: string list) (cUnit: CompilationUnit) : CompilationUnit =
match cUnit with
| FS fs -> FS { fs with Options = options }
| FS fs -> FS { fs with Options = fs.Options @ options }
Copy link
Member

@vzarytovskii vzarytovskii Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought, I've fixed that. Thanks.

| _ -> failwith "withOptions is only supported n F#"

let withPreview (cUnit: CompilationUnit) : CompilationUnit =
match cUnit with
| FS fs -> FS { fs with Options = [ "--langversion:preview" ] }
| FS fs -> FS { fs with Options = fs.Options @ [ "--langversion:preview" ] }
| _ -> failwith "withPreview is only supported in F#"

let asLibrary (cUnit: CompilationUnit) : CompilationUnit =
Expand Down