Refactor smoke-test to capture prereqs #13145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
These changes have passed PR validation and an internal build w/bootstrapping. |
MichaelSimons
changed the title
Member
Author
crummel
approved these changes
Feb 3, 2022
| public static string DotNetDirectory { get; } = Environment.GetEnvironmentVariable("DOTNET_DIR") ?? "./.dotnet"; | ||
| public static string DotNetTarballPath { get; } = Environment.GetEnvironmentVariable(DotNetTarballPathEnv) ?? string.Empty; | ||
| public const string DotNetTarballPathEnv = "DOTNET_TARBALL_PATH"; | ||
| public static bool ExcludeOnlineTests { get; } = Environment.GetEnvironmentVariable("EXCLUDE_ONLINE_TESTS") != null; |
There was a problem hiding this comment.
Suggested change
| public static bool ExcludeOnlineTests { get; } = Environment.GetEnvironmentVariable("EXCLUDE_ONLINE_TESTS") != null; | |
| public static bool ExcludeOnlineTests { get; } = Convert.ToBoolean(Environment.GetEnvironmentVariable("EXCLUDE_ONLINE_TESTS")); |
I think it's more intuitive to avoid the issue with the environment variable being EXCLUDE_ONLINE_TESTS=false causing them to be excluded.
Member
Author
There was a problem hiding this comment.
Fair suggestion. I think I like avoiding exceptions for this scenario though so how about - bool.TryParse(Environment.GetEnvironmentVariable("EXCLUDE_ONLINE_TESTS"), out bool excludeOnlineTests) ? excludeOnlineTests : false;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#2550
./build.sh --run-smoke-testwill now captures all prereq packages downloaded from online sources that are not part of source-build into dotnet-smoke-test-prereqs.xyz.tar.gz in the tarball build output next to the other tarball artifacts. The smoke-tests will now run two passes. Once against online package and a second against source-build packages w/prereqs.